Add a ResultHandler that joins all its entries (JoinEntriesResultHand… #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear Daniel, |
dfish3r
reviewed
Feb 11, 2021
| * | ||
| * @author Middleware Services | ||
| */ | ||
| public class JoinEntriesResultHandler extends AbstractEntryHandler<SearchResponse> implements SearchResultHandler { |
There was a problem hiding this comment.
What do you think about naming this MergeResultHandler ?
There was a problem hiding this comment.
I think it is better. I will change it now, review and push again. Best regards
|
Looks good, thanks for the contribution! Extra props for using Simpson test data. |
|
Dear Daniel, |
|
Planning for a release this month, there are a few other changes in flight. How soon do you need it? |
|
It is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I have added a search handler that uses the SearchResults.merge() function to join (or merge) all the entries by attribute name. I will continue adding the functionality to CAS.
The use case is to collect emails belonging to the same person with the search handler.
The person (the authenticated entry in CAS) is like this:
dn: person:1234,o=people,dc=...
person: 1234
...
The email entries are like this:
dn: my@mail.com,dc=...
mail:, my@mail.com
owner: person:1234,o=people,dc=...
...
Do you need further details or add any unit tests?
Bests regards,
Miguel