CompareAuthenticationHandler skips entry resolution; wrong result code?

[mmoayyed]

When using CompareAuthenticationHandler, successful authentication attempts return the following:

return new AuthenticationHandlerResponse(compareResponse, compareResponse.isTrue() ? 
   AuthenticationResultCode.AUTHENTICATION_HANDLER_SUCCESS : AuthenticationResultCode.AUTHENTICATION_HANDLER_FAILURE, c);

The above response will never be considered success because success for AuthenticationHandlerResponse is determined as:

default boolean isSuccess() {
        return ResultCode.SUCCESS == this.getResultCode();
}

The result-code for compareResponse is always COMPARE_TRUE. Since the response is not considered a success, entry resolvers will not run, resulting in no returned attributes.

I think AuthenticationHandlerResponse should provide an implementation for isSuccess that does this?

boolean isSuccess() {
    return getAuthenticationResultCode() == AUTHENTICATION_HANDLER_SUCCESS;
}

[dfish3r]

Fixed in #198