Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Java module support #212

Closed
jkuhn1 opened this issue May 16, 2022 · 0 comments
Closed

Basic Java module support #212

jkuhn1 opened this issue May 16, 2022 · 0 comments

Comments

@jkuhn1
Copy link

jkuhn1 commented May 16, 2022

Hi,

It appears that MANIFEST.MF doesn't provide the Automatic-Module-Name attribute which makes the library difficult to use with the Java module system.

Without it, the name of the module in a requires directive would be the name of the JAR file which is subject to change leading to compile and runtime issues.

Would it be possible to include this in the build using something like this:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jar-plugin</artifactId>
  <configuration>
    <archive>
      <manifestEntries>
        <Automatic-Module-Name>org.ldaptive</Automatic-Module-Name>
      </manifestEntries>
    </archive>
  </configuration>
</plugin>

In the long run it would be better to convert the library to a Java module by defining a proper module-info.java but the attribute should be enough for now.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant