Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor merge to support operation config. #227

Merged
merged 1 commit into from Dec 8, 2022
Merged

Conversation

dfish3r
Copy link
Member

@dfish3r dfish3r commented Dec 7, 2022

The underlying operations used by the merge operation can now be configured with handlers. Update MergeOperation to expose properties for these operations. Note that this is a behavioral change to the merge as the initial search is no longer guaranteed to occur on the same connection as the following operation. Add copy methods to each operation for consistency.

The underlying operations used by the merge operation can now be configured with handlers.
Update MergeOperation to expose properties for these operations.
Note that this is a behavioral change to the merge as the initial search is no longer guaranteed to occur on the same connection as the following operation.
Add copy methods to each operation for consistency.
Copy link
Member

@serac serac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@serac serac merged commit 3701260 into master Dec 8, 2022
@dfish3r dfish3r deleted the merge-op-refactor branch November 8, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants