memcmp wrongly used

[vteromero]

memcmp compare stream of bytes, not arrays of other bigger types like uint16_t, uint32_t or uint64_t. You can still use it with those types, but you need to properly calculate the number of bytes to compare For example:

const size_t len = 4;
uint32_t a[len] = {0, 1, 2, 3};
uint32_t b[len] = {0, 10, 20, 30};

// WRONG: will output "Arrays are equal"
if (memcmp(a, b, len) == 0) {
  printf("Arrays are equal\n");
} else {
  printf("Arrays are different\n");
}

// CORRECT: will output "Arrays are different"
if (memcmp(a, b, len * sizeof(uint32_t)) == 0) {
  printf("Arrays are equal\n");
} else {
  printf("Arrays are different\n");
}

There are a couple of places where memcmp is being used incorrectly:

• tests/gov2.c
• tests/timestamps.c