Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization is not following the vtex convention #137

Open
eduardopatrick opened this issue Jan 24, 2022 · 0 comments
Open

Internationalization is not following the vtex convention #137

eduardopatrick opened this issue Jan 24, 2022 · 0 comments

Comments

@eduardopatrick
Copy link

When I tried to add a custom translation on label for countries like Peru or Colombia the app only uses it's own translations from the folder /messages instead of reconize for example custom files for especific translations like :
image
image

the result is that I can translate a part of the component, but the edit form only follows the translation of this app:
{ name: 'document', maxLength: 30, placeholder: '', label: setDocumentLabel(locale).value, // for now I'm using a function to check for a translation that matches what I need for the field in each country, but this is not maintainable. hidden: showDocumentField , // Defines if the user can edit the document field or not },

For example if I set the property label as : 'document' , it will give me the translation from es.json under messages folder which is 'documento', instead of get the custom translation for that field from here : https://user-images.githubusercontent.com/33517336/150832019-81e02019-fc25-47b7-962f-33c9e7bbf0e4.png

I think that should follow the same convention as we use in other apps so we can change the label according to the country.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants