Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tvOS support #47 #50

Merged
merged 3 commits into from
May 19, 2016
Merged

tvOS support #47 #50

merged 3 commits into from
May 19, 2016

Conversation

alexpalman
Copy link

Added tvOS support.
It works on tvOS with the changes I made, but the UITextView containing the license text scrolls under the transparent navigation bar, which looks incorrect.
That shouldn't be a deal breaker though, because the text is still readable.

@alexpalman alexpalman changed the title tvOS support tvOS support #47 Apr 20, 2016
@vtourraine
Copy link
Owner

Hello Alex. Sorry about being so slow to comment on this PR (🐢), and thanks for contributing (👍)!

It seems like you made the appropriate changes for the view controllers and the podspec, which is great.

But I think we still need to work on the Xcode project for the framework itself. In the new target for tvOS, we should add the source files to actually compile something, and we should remove the new Info.plist and general header files, and point to the existing files from the main iOS target instead.

I hope that makes sense. You can look at AFNetworking as an example, it already implements the same approach. And if you prefer that I make these changes, just let me know and I’ll work on your branch.

@alexpalman
Copy link
Author

Hi,
no problemo :)
Sorry, I have overlooked that because I immediately tried it in my tvOS project.
I'll make the necessary changes soonish and update the PR accordingly 👍.

Thanks for looking into it!

@alexpalman
Copy link
Author

Sorry for the long delay, but I finally updated the branch. Should be building correctly now.

@vtourraine vtourraine merged commit 99b10b1 into vtourraine:master May 19, 2016
@vtourraine
Copy link
Owner

Awesome! 📺

Now I’ll wait for a couple of days/weeks to see if we receive feedback on these changes, then I’ll ship it with version 1.1.

Thank you once again for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants