Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to provide own localization #15

Closed
orschaef opened this issue May 13, 2016 · 4 comments
Closed

Possibility to provide own localization #15

orschaef opened this issue May 13, 2016 · 4 comments

Comments

@orschaef
Copy link

orschaef commented May 13, 2016

The latest AcknowList update changed my navigationItem title to "Danksagungen" for German localization. This translation is not completely wrong but you would often use another word (like "Lizenzen" what equals "licences")

I would prefer to provide my own localization.

Suggestions:

  • Give possibility to ship a custom .strings file
    or
  • Provide public properties to set the title
@vtourraine
Copy link
Owner

That’s a totally legitimate request, and I think you just need to update the title property (inherited from UIViewController).

@orschaef
Copy link
Author

Well, yes ... thats ok for this certain case. It was too obvious ;) But maybe it makes sense to provide certain properties or any functionality to solve this better in the future?

@vtourraine
Copy link
Owner

Glad to hear that it works.

I’d be happy to improve this use-case, but I don’t want to duplicate an existing property. Do you have any suggestion on how to better address this issue? Maybe we should simply mention this possibility in the readme?

@orschaef
Copy link
Author

Sorry for the late response.

Right at the moment I have no better idea. Let's close the issue for now. If I come around with THE SOLUTION™ I'll contact you again ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants