Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update for Swift 5 #49

Closed
OscarGorog opened this issue Mar 31, 2019 · 11 comments
Closed

Please update for Swift 5 #49

OscarGorog opened this issue Mar 31, 2019 · 11 comments

Comments

@OscarGorog
Copy link
Contributor

OscarGorog commented Mar 31, 2019

Please update for Swift 5 support

Thanks!

@vtourraine
Copy link
Owner

Hello Oscar, and thank you for reaching out. Unfortunately I don’t have the latest Xcode version installed yet, so I can’t test this library with Swift 5.

If you do, feel free to open the workspace, migrate the code to Swift 5 (there’s probably very little change beyond the project settings), and send me a pull request. 🚀

@OscarGorog
Copy link
Contributor Author

Hi Vincent,

I have created a pull request for this update.

Thanks!

@vtourraine
Copy link
Owner

Implemented with #50

@larsschwegmann
Copy link

@vtourraine Could you update the cocoapods spec in the cocoapods trunk repo to use v. 1.9 please? 😄

@vtourraine
Copy link
Owner

@larsschwegmann I’ve tried to push the update earlier this week, but apparently Swift 5 isn’t supported by CocoaPods yet. Unless I’m missing something?

@larsschwegmann
Copy link

@vtourraine Hmm, I've actually never submitted/updated a pod to the cocoapods trunk myself, but other pods that I use already upgraded to Swift 5 and successfully submitted their updated version. Take Moya for example (v. 13.0.0) which uses Swift 5 and depends on Xcode 10.2

What happens exactly when you try to submit it using pod trunk push? ´Do you get an Error message? I would really like to get rid of these annoying warnings in Xcode 😄

@vtourraine
Copy link
Owner

That’s interesting. So they must have used a new beta, or something like that. I’ll look into this as soon as I can, but in the meantime, you should be able to update your Podfile to request a specific commit, thus getting the Swift 5 version from master.

@vtourraine
Copy link
Owner

vtourraine commented Apr 23, 2019

My bad, I misunderstood the error I was getting when trying to push to trunk. The pod tool uses xcodebuild (a.k.a. Xcode) to check the podspec file before pushing it (even with --skip-tests --skip-import-validation --allow-warnings), and like I mentioned, I don’t have the latest Xcode version with Swift 5 installed on my machine. So that's a bummer. 😞

I’m sure I’ll manage to update my machine to Mojave and Xcode 10.2 eventually, but in the meantime, I’m open to suggestions, and hopefully the trick of pointing to master from your Podfile (as mentioned previously) should help you avoid the issue.

@vtourraine vtourraine reopened this Apr 23, 2019
@OscarGorog
Copy link
Contributor Author

OscarGorog commented Apr 23, 2019 via email

@vtourraine
Copy link
Owner

@OkiRules That’s down to professional constraints, basically out of my control.

@vtourraine
Copy link
Owner

@OkiRules Good news: the Swift 5 version is finally available from CocoaPods (v1.9) 🎉

Sorry it took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants