Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to sequence protocol instead of list. #38

Closed
vtraag opened this issue Jun 30, 2018 · 1 comment
Closed

Change to sequence protocol instead of list. #38

vtraag opened this issue Jun 30, 2018 · 1 comment
Assignees
@vtraag
Labels
improvement

Comments

@vtraag
Copy link
Owner

vtraag commented Jun 30, 2018

For generality, it seems preferable to work with the sequence protocal instead of assuming it is a list. This applies to the PyList* Python C API calls in python_optimiser_interface.cpp and python_partition_interface.cpp.
@vtraag vtraag self-assigned this Jun 30, 2018
@vtraag
Copy link
Owner Author

vtraag commented Aug 28, 2018

Looked at it more closely, does not seem worth changing it.

@vtraag vtraag closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vtraag vtraag

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vtraag