Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deep property path not working #526

Merged
merged 2 commits into from
Oct 18, 2018

Conversation

lionel-bijaoui
Copy link
Member

@lionel-bijaoui lionel-bijaoui commented Oct 17, 2018

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

#511

  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:
  • Deactivate paths option in 'lodash-webpack-plugin'

Thanks @qkdreyer

- Deactivate `paths` option in 'lodash-webpack-plugin'
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling fb02f26 on lionel-bijaoui:fix_lodash into 8d245e7 on vue-generators:master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 17, 2018

Coverage Status

Coverage remained the same at 89.916% when pulling fb02f26 on lionel-bijaoui:fix_lodash into 8d245e7 on vue-generators:master.

@zoul0813
Copy link
Member

@lionel-bijaoui can we merge this now?

@lionel-bijaoui lionel-bijaoui merged commit 9f5d842 into vue-generators:master Oct 18, 2018
@lionel-bijaoui
Copy link
Member Author

@zoul0813 Yes !

@lionel-bijaoui lionel-bijaoui deleted the fix_lodash branch October 18, 2018 07:57
@lionel-bijaoui lionel-bijaoui added this to In Progress in v3.0 Oct 18, 2018
@lionel-bijaoui lionel-bijaoui moved this from In Progress to Done in v3.0 Oct 18, 2018
@zoul0813
Copy link
Member

@lionel-bijaoui I just updated one of my projects to the 2.3.2 branch on my fork and I'm still not getting deep property paths loading up ...

when I remove the LodashModuleReplacementPlugin from the webpack config, everything works fine ... when it's included, my "location.city, location.state, location.postalCode" fields don't display values in the inputs.

I think the "opt-in" config is backwards ... you pass "true" to enable the feature in the plugins options object.

I'm not sure which Lodash features we should keep enabled though ...paths and collections seems like something we should enable.

@zoul0813 zoul0813 mentioned this pull request Oct 23, 2018
3 tasks
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Oct 23, 2018
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Oct 29, 2018
* master-origin:
  vue-generators#535, vue-generators#526 - reversed "deep property path" fix
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Oct 29, 2018
* master-origin:
  vue-generators#535, vue-generators#526 - reversed "deep property path" fix
  2.3.2 releases
  Fix Rawgit shut down - Change link to cdnjs
  Export dist
  Fix deep property path not working - Deactivate `paths` option in 'lodash-webpack-plugin'
  docs: replace duplicated 2.3.0 with 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v3.0
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants