Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include parenthesis on mixin calls to support less 4.0.0 #3436

Closed
1 task
icaruseeee opened this issue Dec 23, 2020 · 4 comments
Closed
1 task

Include parenthesis on mixin calls to support less 4.0.0 #3436

icaruseeee opened this issue Dec 23, 2020 · 4 comments

Comments

@icaruseeee
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

ant-design/ant-design@263d8ec
some style didn't work with less 4.0.0. ant-design fixed them at this commit, hope for include parenthesis on mixin calls to support less 4.0.0

What does the proposed API look like?

.reset-component; => .reset-component();
...

@ajuner
Copy link
Member

ajuner commented Dec 24, 2020

less先降到3.x吧 4.0未兼容

@github-actions
Copy link

Hello @icaruseeee. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch, fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @icaruseeee,我们完全同意你的提议/反馈,欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支,务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

@ajuner
Copy link
Member

ajuner commented Dec 28, 2020

#3449

@ajuner ajuner closed this as completed Dec 28, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants