Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Slots #53

Closed
Ubugeeei opened this issue Dec 11, 2023 · 4 comments · Fixed by #143
Closed

Component Slots #53

Ubugeeei opened this issue Dec 11, 2023 · 4 comments · Fixed by #143
Assignees
@Ubugeeei
Labels
on discussing runtime todo PR welcome

Comments

@Ubugeeei
Copy link
Member

Ubugeeei commented Dec 11, 2023 •
edited

related: #4
@Ubugeeei Ubugeeei self-assigned this Dec 11, 2023
@Ubugeeei Ubugeeei mentioned this issue Dec 11, 2023
Closed
@Ubugeeei
Copy link
Member Author

I tried implementing slots, but there seem to be some areas that likely require discussion.
I've created a draft PR, but this is a provisional implementation.
I will compile the points that need to be discussed in this issue soon.

@Ubugeeei Ubugeeei mentioned this issue Dec 11, 2023
Open
28 tasks
@sxzz
Copy link
Member

sxzz commented Dec 12, 2023

Big thanks for awesome your contribution! However, we need to slow down due to my working schedule.

@Ubugeeei
Copy link
Member Author

Ok, I'll wrap up what I've done so far with this issue's note and take a break. 😴
If there's anything low-effort you'd like me to do first, please don't hesitate to ask. (Like adding small tests, etc.)

@Ubugeeei Ubugeeei changed the title [Runtime] Component Slots Component Slots Feb 1, 2024
@Ubugeeei Ubugeeei mentioned this issue Mar 4, 2024
Merged
7 tasks
@sxzz sxzz closed this as completed in #143 Mar 24, 2024
@LittleSound LittleSound mentioned this issue Mar 26, 2024
Merged
@sxzz
Copy link
Member

sxzz commented May 3, 2024

Continues in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ubugeeei Ubugeeei

Labels
on discussing runtime todo PR welcome
Projects
None yet
Milestone
No milestone
2 participants
@sxzz @Ubugeeei