Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] The command hook should return the component instance proxy #74

Closed
baiwusanyu-c opened this issue Dec 19, 2023 · 3 comments
Closed
Labels

Comments

@baiwusanyu-c
Copy link
Member

baiwusanyu-c commented Dec 19, 2023

const instance =
(getExposeProxy(internalInstance) as ComponentPublicInstance) ||
internalInstance.proxy

Should be consistent with the existing runtime, returning a proxy object for the component instance

@sxzz
Copy link
Member

sxzz commented Jan 12, 2024

Is it essential to have a PublicInstance in Vapor mode? Since in vapor mode we don't need to support Options API.

@sxzz
Copy link
Member

sxzz commented Jan 12, 2024

Most properties of public instances benefit from the Options API. I think that when only Composition API is supported, these properties can be obtained using macros defineXXX or getCurrentInstance.

Also, we can plan to publicize some properties returned by getCurrentInstance.

P.S. Sorry for my late reply. My focus isn't on Vapor in recent days.

@sxzz
Copy link
Member

sxzz commented Mar 19, 2024

At this stage, we can avoid public instances and consider not distinguishing between internal and public in the future.

@sxzz sxzz closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@Ubugeeei Ubugeeei mentioned this issue Mar 25, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants