Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Regarding the restrictions on package imports, consider introducing linting or documentation. #80

Closed
Ubugeeei opened this issue Dec 25, 2023 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@Ubugeeei
Copy link
Member

I've noticed in several PRs that there are reviews mentioning not to import runtime-core or compiler-core into vapor.

Indeed, it seems this isn't written anywhere, so we should compile the constraints and either lint the imports or include them in the contribution guide.

Even if we introduce linting, I think it might not be clear how to address it, so documentation is probably better. (Something along the lines of 'please implement by copying').

@Ubugeeei Ubugeeei added the documentation Improvements or additions to documentation label Dec 25, 2023
@Ubugeeei
Copy link
Member Author

Ubugeeei commented Jan 3, 2024

@LittleSound
Thanks! c82ed7d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants