fix(reactivity): avoid infinite loop when render access a side effect computed #11135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnsoncodehk cc this, and we need a ecosystem test as well |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
|
This PR's behaviors in test case are aligned with v3.5.0-alpha.2 as well |
This was referenced Jun 28, 2024
yyx990803
pushed a commit
that referenced
this pull request
Jun 28, 2024
to avoid regressions like in #11135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a new dirty level
MaybeDirty_ComputedSideEffect_Originmark which computed is the original side effect one, and treat it different in triggerEffects and dirty judgementclose #11121