Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): union function prop #3119

Merged
merged 5 commits into from
Mar 25, 2021
Merged

fix(types): union function prop #3119

merged 5 commits into from
Mar 25, 2021

Conversation

07akioni
Copy link
Contributor

Fix union typed function prop's type error.

Reproduction:
https://codesandbox.io/s/smoosh-cherry-q8rv1?file=/src/index.ts

image

@07akioni 07akioni changed the title Fix prop type union function fix(types): union function prop Jan 29, 2021
@HcySunYang HcySunYang requested a review from pikax February 5, 2021 02:45
@07akioni 07akioni mentioned this pull request Mar 4, 2021
Closed
@07akioni 07akioni force-pushed the fix-prop-type-union-function branch from d012e6b to 6c3e293 Compare March 4, 2021 08:19
@07akioni
Copy link
Contributor Author

07akioni commented Mar 4, 2021

@pikax

@HcySunYang HcySunYang linked an issue Mar 4, 2021 that may be closed by this pull request
Regression: union typed prop has wrong type in setup #3357
Closed
@07akioni
Copy link
Contributor Author

07akioni commented Mar 6, 2021 •
edited
Loading

fix #3357

@07akioni
Copy link
Contributor Author

07akioni commented Mar 7, 2021

@HcySunYang Code is reviewed

@07akioni
Copy link
Contributor Author

Any progress?

@yyx990803 yyx990803 merged commit 3755e60 into vuejs:master Mar 25, 2021
@crutchcorn crutchcorn mentioned this pull request Jul 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression: union typed prop has wrong type in setup
4 participants
@07akioni @pikax @yyx990803 @LinusBorg