fix(ssr/renderToStream): A Readable object should at least implement an empty _read method. #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an empty _read method. Nor it will throw errors. See nodejs/node#38865. The tests passes in jest before because jest mock the global promise and causes inconsistant behavior compared with native nodejs. jestjs/jest#11497
|
fix #3846 |
posva
reviewed
Jun 1, 2021
|
PR was stale due to SSR refactor in 3.2 so I landed it in a separate commit. |
iwusong
pushed a commit
to iwusong/core
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nor it will throw errors.
See nodejs/node#38865.
The tests passes in jest before because jest mock the global promise and causes inconsistant behavior compared with native nodejs.
jestjs/jest#11497
fix #3846