Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on unmount when async component is passed through a slot to suspense #4198

Closed
yaquawa opened this issue Jul 27, 2021 · 3 comments
Closed

on unmount when async component is passed through a slot to suspense #4198

yaquawa opened this issue Jul 27, 2021 · 3 comments
Labels
🐞 bug Something isn't working scope: suspense

Comments

@yaquawa
Copy link

yaquawa commented Jul 27, 2021 •
edited by posva
Loading

Version

3.2.0-beta.5

Reproduction link

Playground

Steps to reproduce

  • Click the toggle button twice
  • Check the logs

What is expected?

Should log unmounted twice but it logs only once
@edison1105
Copy link
Member

edison1105 commented Jul 27, 2021 •
edited
Loading

duplicate of #4183, the dynamicChildren is an empty array and will be fixed in #4186 (if it's the right fix😄)

@yaquawa
Copy link
Author

yaquawa commented Jul 27, 2021

@edison1105 Thanks! I've subscribed the PR.

@posva posva changed the title "unmount" event won't be triggered if use <suspense> in a SFC on unmount when async component is passed through a slot to suspense Jul 27, 2021
@posva
Copy link
Member

posva commented Jul 27, 2021

Updated the repro so it doesn't contain vue router

@posva posva added 🐞 bug Something isn't working scope: suspense labels Jul 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working scope: suspense
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@posva @edison1105 @yaquawa