Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): Keep the url logic of src and srcset mostly consistent #4834

Closed
wants to merge 1 commit into from
Closed

fix(compiler-sfc): Keep the url logic of src and srcset mostly consistent #4834

wants to merge 1 commit into from

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Oct 22, 2021

fix #4819

@Bigfish8
Copy link
Contributor

😂Sorry, I Did not notice that you have already committed for this issue.
It is my PR #4835.
The difference is treatment for mixin url.

@ElMassimo ElMassimo mentioned this pull request Nov 12, 2021
Closed
2 tasks
@yyx990803 yyx990803 added this to Open for Review in Next Patch May 10, 2022
@yyx990803 yyx990803 moved this from Open for Review to High Priority in Next Patch May 10, 2022
@yyx990803 yyx990803 closed this in 41d255b May 11, 2022
@yyx990803
Copy link
Member

I think #4835 handles the case of mixed URLs better so I based 41d255b off of that.

@yyx990803 yyx990803 moved this from High Priority to Done in Next Patch May 11, 2022
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@yyx990803 @iwusong
fix(compiler-sfc): fix skipped srcset transform when using base option
e434d1c 
Based on implementation from vuejs#4835 due to conflicts

fix vuejs#4819
close vuejs#4834, close vuejs#4835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: sfc
Projects
Next Patch
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative URLs in srcset are not transformed
3 participants
@ygj6 @Bigfish8 @yyx990803