Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transition): v-show false should not call onEnter #4852

Closed
wants to merge 5 commits into from
Closed

fix(transition): v-show false should not call onEnter #4852

wants to merge 5 commits into from

Conversation

zhaozhongyu
Copy link

…directiveHooks
fix: #4845

edison1105
edison1105 requested changes Oct 25, 2021
View reviewed changes
packages/runtime-core/src/renderer.ts Outdated
@@ -617,6 +618,7 @@ function baseCreateRenderer(
}
}

// 首次渲染或v-if渲染, mounted回调
Copy link
Member

@edison1105 edison1105 Oct 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这些注释是没有必要的。大哥，就算注释也不能用中文啊。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思, 习惯性加注释误提交了

posva
posva requested changes Oct 25, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

@posva posva changed the title fix(runtime-core): v-show transition hooks should be call via v-show … fix(transition): v-show false should not call onEnter Oct 25, 2021
@yyx990803 yyx990803 added this to Open for Review in Next Patch May 10, 2022
@yyx990803 yyx990803 closed this in 425310e May 11, 2022
@yyx990803
Copy link
Member

Thanks for the PR, but hard code checking _vod isn't the best way to do this. The renderer is already checking if the transition is in persisted mode, but I realized there was no compile-time logic to put v-show transitions in persisted mode. Fixed in 425310e which uses part of the tests in this PR.

@yyx990803 yyx990803 moved this from Open for Review to Done in Next Patch May 11, 2022
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@yyx990803 @iwusong
fix(transition/v-show): ensure transition is in persisted mode when u…
f2b72c0 
…sed with v-show

fix vuejs#4845
close vuejs#4852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva requested changes

@edison1105 edison1105 edison1105 requested changes

Assignees
No one assigned
Labels
None yet
Projects
Next Patch
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onEnter of transition component is fired when its child is set to v-show="false"
4 participants
@zhaozhongyu @yyx990803 @posva @edison1105