Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): don't warn for missing teleport target if disabled #5135

Merged
merged 1 commit into from
May 11, 2022
Merged

fix(ssr): don't warn for missing teleport target if disabled #5135

merged 1 commit into from
May 11, 2022

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Dec 17, 2021

@LinusBorg LinusBorg added this to In Review in Next Patch Mar 15, 2022
@LinusBorg LinusBorg moved this from In Review to Planned, might need fresh review in Next Patch Mar 15, 2022
@KaelWD KaelWD force-pushed the fix/ssr-teleport-target-warning branch from c9f8917 to 449cfcc Compare March 16, 2022 07:54
@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

🔨 Explore the source changes: 449cfcc

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/623197b83a850700089517fb

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 449cfcc

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/623197b81a9f2b00089c7201

😎 Browse the preview: https://deploy-preview-5135--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Mar 16, 2022 •
edited
Loading

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 449cfcc

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/623197b8dfa4cb000847890b

😎 Browse the preview: https://deploy-preview-5135--vue-next-template-explorer.netlify.app

Next Patch automation moved this from Planned, might need fresh review to Approved Mar 18, 2022
@LinusBorg LinusBorg added scope: teleport 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Mar 18, 2022
@yyx990803 yyx990803 merged commit da10dd7 into vuejs:main May 11, 2022
Next Patch automation moved this from Approved by a team member to Done May 11, 2022
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@KaelWD @iwusong
fix(ssr): don't warn for missing teleport target if disabled (vuejs#5135
d87deff 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusBorg LinusBorg LinusBorg approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: teleport
Projects
Next Patch
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KaelWD @LinusBorg @yyx990803