Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): Ensure raw Slots are only normalized once by withContext (Fix: #5353) #5358

Merged
merged 1 commit into from May 10, 2022

Conversation

LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Feb 3, 2022

This PR ensures that an already normalized slot isn't normalized again, which could potentially lead to a "max stack" error from too many nested function calls (aside from simply being unnecessary work).

I didn't add a test case as this change doesn't have a public effect I could test against - if all tests still pass this should be fine.

But I can come up with one if necessary.

close: #5353

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 604420b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61fc3abf6e92c60008a17b5f

😎 Browse the preview: https://deploy-preview-5358--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 604420b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61fc3abf778ebb00071b3f3a

😎 Browse the preview: https://deploy-preview-5358--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 604420b

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61fc3abf3ba4b60008251b80

😎 Browse the preview: https://deploy-preview-5358--vue-next-template-explorer.netlify.app

@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg moved this from Planned, might need fresh review to In Review in Next Patch Mar 10, 2022
@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. and removed 🔩 p2-edge-case labels Mar 11, 2022
@yyx990803 yyx990803 merged commit e4dffe9 into main May 10, 2022
Next Patch automation moved this from Open for Review to Done May 10, 2022
@yyx990803 yyx990803 deleted the linusborg/normalize-rawslot-fix-5353 branch May 10, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: slots
Projects
Development

Successfully merging this pull request may close these issues.

"Maximum call stack size exceeded" when using v-show on a component using transition as root element
3 participants