-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-sfc): v-bind using // to comment will still compile #5409
Conversation
✔️ Deploy Preview for vue-next-template-explorer ready! 🔨 Explore the source changes: 5cc64eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/62068188abf02a00073d49b8 😎 Browse the preview: https://deploy-preview-5409--vue-next-template-explorer.netlify.app |
✔️ Deploy Preview for vue-sfc-playground ready! 🔨 Explore the source changes: 5cc64eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/62068188913dca0007adbb1a 😎 Browse the preview: https://deploy-preview-5409--vue-sfc-playground.netlify.app/ |
❌ Deploy Preview for vuejs-coverage failed. 🔨 Explore the source changes: 5cc64eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620681889b56b200084c0bba |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
When I use scss, if I write v-bind and comment it out, the v-bind line of css is still compiled as a css variable
Here is a default project I created using "@vue/cli 4.5.15"
The line is actually commented out by css, but the v-bind variables are still compiled into the styles of the nav tag
Comments about sass