Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-dom): should bail when node uses html directives. #5445

Closed
wants to merge 1 commit into from
Closed

fix(compiler-dom): should bail when node uses html directives. #5445

wants to merge 1 commit into from

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Feb 17, 2022

fix: #5439

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 1801f74

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/620f03186ce64a0007f272c2

😎 Browse the preview: https://deploy-preview-5445--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 1801f74

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/620f0318cd4ece0007927485

😎 Browse the preview: https://deploy-preview-5445--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 17, 2022 •
edited
Loading

❌ Deploy Preview for vuejs-coverage failed.

🔨 Explore the source changes: 1801f74

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/620f03182225080008722b8d

@ygj6 ygj6 changed the title fix(compiler-dom): Disable hoisting in node using html directives. fix(compiler-dom): Disable static hoisting when node uses html directives. Feb 17, 2022
@ygj6 ygj6 changed the title fix(compiler-dom): Disable static hoisting when node uses html directives. fix(compiler-dom): should bail when node uses html directives. Feb 18, 2022
@yyx990803 yyx990803 closed this in 6283b2e May 13, 2022
@yyx990803
Copy link
Member

v-html with constant value is stringifiable, we just didn't implement the logic for it. See 6283b2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-html render some random issue
2 participants
@ygj6 @yyx990803