Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): AsyncComponent work with KeepAlive #5459

Merged
merged 4 commits into from
May 12, 2022
Merged

fix(runtime-core): AsyncComponent work with KeepAlive #5459

merged 4 commits into from
May 12, 2022

Conversation

edison1105
Copy link
Member

fix #5095

@netlify
Copy link

netlify bot commented Feb 19, 2022 •
edited
Loading

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 90d2ddd

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/621102bd295abc0008fe6b61

😎 Browse the preview: https://deploy-preview-5459--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 19, 2022 •
edited
Loading

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 90d2ddd

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/621102bd295abc0008fe6b5d

😎 Browse the preview: https://deploy-preview-5459--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Feb 19, 2022 •
edited
Loading

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 90d2ddd

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/621102bd1c82870009586c81

😎 Browse the preview: https://deploy-preview-5459--vuejs-coverage.netlify.app

@LinusBorg LinusBorg added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: keep-alive labels Mar 10, 2022
@yyx990803 yyx990803 merged commit f1d1cdb into vuejs:main May 12, 2022
yyx990803 added a commit that referenced this pull request May 12, 2022
@yyx990803
fix(keep-alive): invoke initial activated hook for async components
20ed16f 
revert #5459
fix #5095
fix #5651
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@edison1105 @iwusong
fix(runtime-core): fix activated hook when using async component with…
a6dd545 
… KeepAlive (vuejs#5459)

fix vuejs#5095
fix vuejs#5651
iwusong pushed a commit to iwusong/core that referenced this pull request May 13, 2022
@yyx990803 @iwusong
fix(keep-alive): invoke initial activated hook for async components
9ddff44 
revert vuejs#5459
fix vuejs#5095
fix vuejs#5651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: keep-alive
Projects
Next Patch
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

activated hook is not called when using defineAsyncComponent
3 participants
@edison1105 @yyx990803 @LinusBorg