fix(compiler-core): missing source and have with multiple spaces should emit error during compiler #5821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hunyan-io
suggested changes
Apr 29, 2022
| @@ -308,7 +308,7 @@ export function processFor( | |||
| } | |||
| } | |||
|
|
|||
| const forAliasRE = /([\s\S]*?)\s+(?:in|of)\s+([\s\S]*)/ | |||
| const forAliasRE = /([\s\S]*?)\s+(?:in|of)\s+(\S[\s\S]*)/ | |||
There was a problem hiding this comment.
This change looks good to me, but this line has moved since this PR was first opened. It can now be found at:
core/packages/compiler-core/src/utils.ts
Line 502 in 94b9b37
yyx990803
force-pushed
the
hotfix/compiler-vFor
branch
from
c31788b
to
ee65aa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5819