Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): these attrs should be set in chreateElement #6012

Closed
wants to merge 2 commits into from
Closed

fix(runtime-dom): these attrs should be set in chreateElement #6012

wants to merge 2 commits into from

Conversation

zhmushan
Copy link
Contributor

close #6007

b-d-k
b-d-k approved these changes May 26, 2022
View reviewed changes
Copy link

@b-d-k b-d-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in vue-sfc-playground.netlify.app, and it appears to be working. Thank you.

dsonet
dsonet suggested changes Jun 3, 2022
View reviewed changes
packages/runtime-dom/src/nodeOps.ts Outdated Show resolved Hide resolved
LinusBorg
LinusBorg requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix is fine in terms of what it does, but these checks should be part of shouldSetAsProp where we already handle a few other special cases.

@sodatea sodatea added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. wait changes labels Mar 29, 2024
@yyx990803 yyx990803 closed this in 537a571 May 31, 2024
@zhmushan zhmushan deleted the nodeops branch June 3, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsonet dsonet dsonet requested changes

@LinusBorg LinusBorg LinusBorg requested changes

@b-d-k b-d-k b-d-k approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. wait changes
Projects
Issue / PR Management
Status: Rejected
Milestone
No milestone
5 participants
@zhmushan @dsonet @b-d-k @LinusBorg @sodatea