fix(server-renderer): fix the bug that multi slot scope id does not work on component #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork on component Split slot scope id before use it as attribute name so it don't break rendering. Add a test for this bug.
mmis1000
force-pushed
the
fix/server-rednerer-slot-scope-id
branch
from
fbea64f
to
6cb9270
Compare
|
It's almost one year after I opened this pull request. It shouldn't really take that long for a pull request that comes with a proper reproduction and test. And let alone it is just a 4 line change patch. 🫤 |
sodatea
added
scope: slots
scope: ssr
🔨 p3-minor-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6093
Split slot scope id before use it as attribute name so it don't break rendering.
Add a test for this bug.