Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0-alpha.4 can't use webpack project #664

Closed
veaba opened this issue Jan 28, 2020 · 5 comments
Closed

Version 3.0.0-alpha.4 can't use webpack project #664

veaba opened this issue Jan 28, 2020 · 5 comments

Comments

@veaba
Copy link
Member

veaba commented Jan 28, 2020

Version

3.0.0-alpha.4

Reproduction link

https://github.com/veaba/ncov/tree/master/client

Steps to reproduce

New version is bad

What is expected?

The version 3.0.0-alpha.4 is bad,
Yesterday's version is good. I noticed that Vue next released a new version of v3.0.0-alpha.4 nine hours ago. This version has problems and cannot be used in webpack projects

What is actually happening?

Will be support webpack project


Error

runtime-dom.esm-bundler.js:12 Uncaught TypeError: parent.appendChild is not a function
    at insert (runtime-dom.esm-bundler.js:12)
    at processCommentNode (runtime-core.esm-bundler.js:1883)
    at patch (runtime-core.esm-bundler.js:1847)
    at render (runtime-core.esm-bundler.js:2828)
    at mount (runtime-core.esm-bundler.js:1411)
    at Object.app.mount (runtime-dom.esm-bundler.js:1074)
    at Module../src/main.js (main.js:4)
    at __webpack_require__ (bootstrap:726)
    at fn (bootstrap:100)
    at Object.0 (draw.js:43)

The webpack project here: https://github.com/veaba/ncov/tree/master/client

@veaba
Copy link
Member Author

veaba commented Jan 28, 2020

alpha 4 =>

image

alpha 3 =>
image

@LinusBorg
Copy link
Member

Can't run your repo right now but: have you tried it with an updated verion of @vue/sfc-compiler as well? Your current lockfile still refers to alpha-1:

"@vue/compiler-sfc@^3.0.0-alpha.1":
  version "3.0.0-alpha.1"

Just like vue-template-compiler in Vue 2, this dependency has to be kept in sync with the Vue version that's being used.

@veaba
Copy link
Member Author

veaba commented Jan 28, 2020

Can't run your repo right now but: have you tried it with an updated verion of @vue/sfc-compiler as well? Your current lockfile still refers to alpha-1:

"@vue/compiler-sfc@^3.0.0-alpha.1":
  version "3.0.0-alpha.1"

Just like vue-template-compiler in Vue 2, this dependency has to be kept in sync with the Vue version that's being used.

It seems that vue-next is updated, but @vue/compiler-sfc is not!

@vue/compiler-sfc verson is 3.0.0-alpha.1

@veaba
Copy link
Member Author

veaba commented Jan 28, 2020

rolled back vue@3.0.0-alpha.3

@posva
Copy link
Member

posva commented Jan 28, 2020

You need to adapt the mounting code:

-const app = createApp()
+const app = createApp(App)
-app.mount(App, '#app')
+app.mount('#app')

This was one of the breaking changes: v3.0.0-alpha.3...v3.0.0-alpha.4
Changelog

@posva posva closed this as completed Jan 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants