Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): v-model w/ select #7432

Merged
merged 6 commits into from Jul 11, 2023
Merged

fix(ssr): v-model w/ select #7432

merged 6 commits into from Jul 11, 2023

Conversation

edison1105
Copy link
Member

close #7392

@LinusBorg LinusBorg added scope: ssr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. labels Jan 9, 2023
@sodatea

This comment was marked as outdated.

@vue-bot

This comment was marked as outdated.

@sodatea
Copy link
Member

sodatea commented Feb 10, 2023

Sorry, I forgot that ecosystem-ci could only be run when the PR is up-to-date with the main branch. Now force pushed.

/ecosystem-ci run

@sodatea
Copy link
Member

sodatea commented Feb 10, 2023

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Feb 10, 2023

📝 Ran ecosystem CI: Open

suite result
nuxt ✅ success
pinia ✅ success
router ✅ success
test-utils ✅ success
vite-plugin-vue ✅ success
vitepress ✅ success

@sodatea
Copy link
Member

sodatea commented Feb 10, 2023

The Ecosystem CI is all green now. But the snapshot test failed, and I can't understand the error message. Could you take a look?

@edison1105
Copy link
Member Author

The Ecosystem CI is all green now. But the snapshot test failed, and I can't understand the error message. Could you take a look?

just update the snapshot, all test green now.

@yyx990803 yyx990803 merged commit 201c46d into vuejs:main Jul 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select box with v-model updates lazy when mounting the component
5 participants