Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The page has a memory leak when the page has svg components #8790

Closed
Mario34 opened this issue Jul 15, 2023 · 3 comments
Closed

The page has a memory leak when the page has svg components #8790

Mario34 opened this issue Jul 15, 2023 · 3 comments
Labels
🐞 bug Something isn't working

Comments

@Mario34
Copy link

Mario34 commented Jul 15, 2023 •
edited
Loading

Vue version

3.3.4

Link to minimal reproduction

https://play.vuejs.org/#eNqNVFtv2jAU/itnfimV2gTCJBBK0VZWaZ20rlr3mBcIJ8HFsSPbSVBR/vuOEwiXrmiBB/t85/Kdm7fsa557ZYFswkITa55bMGiLHMRcpncRsyZi00jyLFfawhY0JlBDolUGV2R21UHfMFM7uee7i/N6gF/K9DFWstPY3XdKdDIWSm74QuAA7lyYXjIXBq/PwOAMDP2WNXGki8UsF3OLdAMIF4W1FPJLLHi8plyO/H/anyk7U3Ebr7rood/aXfThaOx9BO98BKc+lryE8pYnRxSaogJ9YVO3iSwyQgd9+iIGfmvnk+FHHlzQnYd9aVur/3IZ+keVcj92Q50mJwlPvVejJI3D1hlELFZZzgXqX7nl1IiITaBBHDYXQlU/GpnVBd7s5fEK4/U/5K9m42QRe9ZoUJcYsQ6zc52ibeGHlyfc0LkDM7UsBGlfAH+jUaJwHFu1+0IuifaRXsP2sRlHLtM/5mFjUZp9Uo6o06wbfapzgbMLqR/oDr1hYxfJmqp4NNdupU4H0pQpjQhW92pDrelDHz6P6U/tSbgQJJJKUpawyYQ0dF1Zm098v6oqrxp6Sqd+QN30yQ0pGavVGkkrLrRGaWdKKEp3GuZzu4IlAT9HMFoNhuVg+H30lgUD6O9uwfiNsGD8ERgxf0qLVaano0Lp7Rf7fW67RSlvE6UpNgcugUaQiHa7o+TMnXr8mmhut7yuobU6Wpezybz0Ji0x4RKftcpN2PSFwk3gqcgW1HZZT3v0PCSFjF3z4BC77aF7VJRAT6jU8ZHUvu4pYfVfmgiukg==

Steps to reproduce

Switch visible1 and visible2 and observe the number of 'Dom nodes' in the Performance monitor panel

image

What is expected?

Unmounted 'Dome nodes' are reclaimed

What is actually happening?

Unmounted 'Dome nodes' are reclaimed

System Info

No response

Any additional comments?

No response
@edison1105 edison1105 added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Jul 16, 2023
@edison1105 edison1105 mentioned this issue Jul 16, 2023
Closed
@Mario34
Copy link
Author

Mario34 commented Jul 17, 2023

Memory leaks have been bothering us for a long time, and we finally found the cause

@Mario34 Mario34 changed the title When the page has svg components, the page elements are not reclaimed The page has a memory leak when the page has svg components Jul 18, 2023
@Mario34 Mario34 mentioned this issue Jul 18, 2023
Closed
@edison1105 edison1105 removed the ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. label Jul 18, 2023
@Mario34
Copy link
Author

Mario34 commented Jul 18, 2023

It similer to #5363 Note: without svg it also has a memory leak

In fact, in my project, the Dom node can be reclaimed after the svg component is removed, so I have provided a reproduced example based on the fact. The issue mentioned in #5363 has been fixed, it should not be the same as the issue I described.

@edison1105
Copy link
Member

edison1105 commented Jul 18, 2023 •
edited
Loading

@Mario34 see #5363 (comment)
Chrome doesn't seem to fix the problem in #5363 and I tested the case where there was a memory leak without svg based on your demo.

I tested #5363 and it was fixed, the reviews misled me.
And no svg node does not have a memory leak. My bad.

@Mario34
duplicate of #5256
a workaround see #5256 (comment)

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): properly remove children for block nodes edison1105/vuejs-core
2 participants
@edison1105 @Mario34