feat(compiler-core): add current filename to TransformContext #8950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `nodeTransform`, I have found myself needing the filename to do filesystem operations, which well cannot be done without the filename of the current component in the context passed to the function
Tofandel
changed the title
Tofandel
changed the title
Tofandel
force-pushed
the
main-1
branch
2 times, most recently
from
6ea9062
to
1c5f431
Compare
sxzz
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
nodeTransform, I have found myself needing the absolute path in which the component is to do filesystem operations, which well cannot be done without that and I don't think a fork of the compiler is warranted for just that ;)Since we already have this available to infer the component name, why not just pass it in the context to make it available to hooks?
This has no effect to the core and just allows plugins to use the current filename in hooks like
nodeTransformsanddirectiveTransforms