Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): return value of vue compat set() #9377

Merged
merged 1 commit into from Oct 19, 2023

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Oct 11, 2023

According to https://v2.vuejs.org/v2/api/#Vue-set, the expected behavior is:

Returns: the set value.

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Oct 12, 2023
@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB 32.6 kB 29.5 kB
vue.global.prod.js 132 kB 49.3 kB 44.4 kB

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.8 kB 17.2 kB
createSSRApp 50.6 kB 19.9 kB 18.2 kB
defineCustomElement 50.3 kB 19.6 kB 17.9 kB
overall 61.2 kB 23.7 kB 21.6 kB

@yyx990803 yyx990803 merged commit e3c2d69 into vuejs:main Oct 19, 2023
11 checks passed
yyx990803 pushed a commit that referenced this pull request Oct 21, 2023
lumozx pushed a commit to lumozx/core that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants