Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Suspense): properly get anchor when mount fallback vnode #9770

Merged
merged 4 commits into from Dec 8, 2023
Merged

fix(Suspense): properly get anchor when mount fallback vnode #9770

merged 4 commits into from Dec 8, 2023

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 7, 2023 •
edited

close #9769

Revert part of #9309 code. #8185 doesn't need this change
When mounting the fallback vnode, we must get the anchor first because the activeBranch will unmount.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.9 kB (+4 B) 33 kB 29.8 kB (+11 B)
vue.global.prod.js 133 kB (+4 B) 49.9 kB 44.7 kB (+30 B)

Usages

Name Size Gzip Brotli
createApp 48.3 kB 19 kB 17.3 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.7 kB 18 kB
overall 61.7 kB (+4 B) 23.8 kB (-4 B) 21.7 kB (+10 B)

@yyx990803 yyx990803 merged commit b700328 into vuejs:main Dec 8, 2023
11 checks passed
@manniL manniL mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since last update Suspense with RouterView acting weird
2 participants
@edison1105 @yyx990803