Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): fix crash when modifier is empty #9866

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

baiwusanyu-c
Copy link
Member

close: #9865

Copy link

github-actions bot commented Dec 19, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB 33.1 kB 29.9 kB
vue.global.prod.js 133 kB 50 kB 44.8 kB

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB 19.8 kB 18.1 kB
overall 61.7 kB 23.9 kB 21.7 kB

Copy link

codspeed-hq bot commented Dec 19, 2023

CodSpeed Performance Report

Merging #9866 will not alter performance

Comparing baiwusanyu-c:bwsy/fix/emptyModifier (27b2503) with main (04d2c05)

Summary

✅ 53 untouched benchmarks

@baiwusanyu-c baiwusanyu-c marked this pull request as draft December 19, 2023 01:08
@baiwusanyu-c baiwusanyu-c changed the title fix(runtime-dom): fix crash when modifier is empty fix(compiler-core): fix crash when modifier is empty Dec 19, 2023
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review December 19, 2023 01:59
@yyx990803 yyx990803 merged commit bae79dd into vuejs:main Dec 19, 2023
13 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/emptyModifier branch December 19, 2023 09:10
@elizatlawy
Copy link

In which version this is deployed?

@EmilyRagan
Copy link

@elizatlawy looks like 3.3.13, according to the change log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

event modifier breaks if handler is undefined
4 participants