Bump eslint-plugin-eslint-plugin to v5
#2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
the
meta
fixes `eslint-plugin/require-meta-type` lint issues
fixes `eslint-plugin/prefer-message-ids` lint issues
FloEdelmann
force-pushed
the
eslint-plugin-eslint-plugin
branch
from
27a07eb
to
a634e35
Compare
because `all` preset can change in minor versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
eslint-plugin-eslint-pluginfrom v3 to v5, and also switches from therecommendedto theallpreset config. This enables many more rules that improve consistency in our codebase. I've also fixed all new lint issues, or disabled the rules where it makes sense.I noticed someeslint-plugin-eslint-pluginrules that now error in our codebase and fixed them upstream:IgnoreSpreadExpressions inno-only-testsandprefer-output-nulleslint-community/eslint-plugin-eslint-plugin#362fix: Ignore function calls inreport-message-formateslint-community/eslint-plugin-eslint-plugin#363While those are not merged and released, I've disabled the rules in files where they error.My fixes are already merged/cherry-picked and released, and I updated this branch accordingly.
Please review each commit individually, the commit descriptions should be self-explanatory.