fix(no-useless-mustaches): escape < in fixes #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ota-meshi
force-pushed
the
no-useless-mustaches-no-fix-for-invalid-html
branch
from
a603614
to
808762d
Compare
ota-meshi
requested changes
Feb 2, 2024
|
There is still a lint error, so please run |
FloEdelmann
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2384
I looked up the parser specification for the inside tag case for potential additional cases which would differ:
<: already covered in the issueEOF: would already be an error\0: I guess/hope no one would do this but there is a difference&: there are cases when combining the text with either before or after the mustache but is also highly unlikelySo this PR only adds escaping
<with<in the fixer.