Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.36.0 breaks Vue SFC's and tests with @vue/test-utils #1386

Closed
TheDutchCoder opened this issue Jun 3, 2022 · 6 comments
Closed

0.36.0 breaks Vue SFC's and tests with @vue/test-utils #1386

TheDutchCoder opened this issue Jun 3, 2022 · 6 comments
Labels
duplicate This issue or pull request already exists

Comments

@TheDutchCoder
Copy link

TheDutchCoder commented Jun 3, 2022

Since the new version (0.36.0), TS will throw errors for things like data- attributes and aria- attributes in Vue SFC files, as well as throw errors when mounting components in tests with @vue/test-utils.

Installing 0.35.2 fixes the issue

0.35.2:
image

0.36.0:
image

@decito
Copy link

decito commented Jun 3, 2022

Not only the data-test-id attribute, but all non-natives attributes, such as windicss attributify

@myknbani
Copy link

myknbani commented Jun 3, 2022

I can confirm this bug as well. All my data-testid attributes started becoming red.

I'll try the comment here

@myknbani
Copy link

myknbani commented Jun 4, 2022

Comment on #1077 (comment) works
Screenshot from 2022-06-04 09-20-40

@TheDutchCoder
Copy link
Author

Why would you have to explicitly declare the already valid attributes?

This change makes no sense to me, any data-* attribute is already according to spec and TS is well aware of it.

I don't understand why this has to be whitelisted. This seems like an unwelcome regression.

@jzs11
Copy link

jzs11 commented Jun 4, 2022

Please take a look...

@johnsoncodehk
Copy link
Member

Duplicate of #1383

@johnsoncodehk johnsoncodehk marked this as a duplicate of #1383 Jun 4, 2022
@johnsoncodehk johnsoncodehk added the duplicate This issue or pull request already exists label Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

5 participants