Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher globs can be simplified #2051

Closed
rchl opened this issue Oct 23, 2022 · 0 comments
Closed

Watcher globs can be simplified #2051

rchl opened this issue Oct 23, 2022 · 0 comments

Comments

@rchl
Copy link
Collaborator

rchl commented Oct 23, 2022

Those separate watch patterns:

https://github.com/johnsoncodehk/volar/blob/40d703fd0bb26542488add9957cd00d99af990a3/packages/language-server/src/server.ts#L97-L105

could be simplified into one. From the LSP spec:

 - `{}` to group conditions (e.g. `**​/*.{ts,js}` matches all TypeScript and JavaScript files)

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didChangeWatchedFiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rchl