Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support typescript pnp #248

Closed
harrytran998 opened this issue Jun 5, 2021 · 7 comments
Closed

[Enhancement] Support typescript pnp #248

harrytran998 opened this issue Jun 5, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@harrytran998
Copy link

harrytran998 commented Jun 5, 2021

In typescript files, I can choose the TS version 4.3.2-pnpify like the image below.
image

But in the .vue file, I can't choose the version like above

image

Additionally, it's the warning of volar

Cannot import Vue 3 types from @vue/runtime-dom. If you are using Vue 2, you may need to install @vue/runtime-dom in additionally.

Hope you can implement it!

@AlexandreBonaventure
Copy link

This is more a yarn pnp problem than anything. Follow this issue: yarnpkg/berry#2986

@harrytran998
Copy link
Author

Oops, thank you for that! I will follow that!

@johnsoncodehk
Copy link
Member

johnsoncodehk commented Jun 7, 2021

This is more a yarn pnp problem than anything. Follow this issue: yarnpkg/berry#2986

I have no idea about this issue, so thank you for posting related issues! Fixed in 0.25.21.

@johnsoncodehk johnsoncodehk added the enhancement New feature or request label Jun 7, 2021
@merceyz
Copy link
Contributor

merceyz commented Jun 7, 2021

I don't think that's the right fix, the tsserver.js file isn't the same as tsserverlibrary.js

0.25.21 is now crashing instantly with this error:

{"seq":0,"type":"event","event":"typingsInstallerPid","body":{"pid":2796}}
[Error - 00:45:51] Request textDocument/foldingRange failed.
  Message: Request textDocument/foldingRange failed with message: Cannot read property 'VariableDeclaration' of undefined
  Code: -32603 

@johnsoncodehk
Copy link
Member

@merceyz please try TS 4.3.2 instead of 4.3.2-pnpify, if the problem only occur in 4.3.2-pnpify, it should be upstream problem.

@merceyz
Copy link
Contributor

merceyz commented Jun 19, 2021

Yeah, we were returning the wrong object, will be fixed with yarnpkg/berry#2995. I couldn't get go to definition to work but everything else looks to be working fine.

@johnsoncodehk
Copy link
Member

Due to upstream already supported tsserverlibrary.js, we will reuse tsserverlibrary.js in 0.26.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants