Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Vue's .prop modifier shorthand syntax #3727

Closed
GrantGryczan opened this issue Nov 10, 2023 · 8 comments · Fixed by #3729
Closed

Support for Vue's .prop modifier shorthand syntax #3727

GrantGryczan opened this issue Nov 10, 2023 · 8 comments · Fixed by #3729
Labels
enhancement New feature or request

Comments

@GrantGryczan
Copy link

GrantGryczan commented Nov 10, 2023

image

image

Even though both of the above are functionally equivalent, in VS Code the latter doesn't get syntax-highlighted, it doesn't get IDE autocomplete, and it doesn't get covered by Vue's ESLint plugin.

Note: TypeScript (in Volar takeover mode, haven't tested otherwise) does still check the contents though, at least.

image

@so1ve
Copy link
Member

so1ve commented Nov 11, 2023

Where is the upstream rfc / implementation PR?

@GrantGryczan
Copy link
Author

GrantGryczan commented Nov 11, 2023

@so1ve It was added in this commit: vuejs/vue@d2902ca

I don't see a corresponding RFC.

@so1ve
Copy link
Member

so1ve commented Nov 11, 2023

Thanks! This seems to be a Vue 2-only feature.

@GrantGryczan
Copy link
Author

GrantGryczan commented Nov 11, 2023

Thanks! This seems to be a Vue 2-only feature.

@so1ve What makes you think so? As linked in my original issue, it's in the Vue 3 documentation. Also, I've tested it myself to work in Vue 3.

@so1ve
Copy link
Member

so1ve commented Nov 11, 2023

I see 👍

@so1ve so1ve added the enhancement New feature or request label Nov 11, 2023
@so1ve
Copy link
Member

so1ve commented Nov 11, 2023

Completion and diagnostics should work normally, but the syntax highlighting is broken if I understand correctly?

@GrantGryczan
Copy link
Author

GrantGryczan commented Nov 11, 2023

Syntax highlighting, completion, and linting are not working. I only noted that type checking works, but I don't think that's necessarily related, only a side note.

@so1ve
Copy link
Member

so1ve commented Nov 12, 2023

I've double checked this issue - completion is working for me, only the highlighting is broken. I have a PR to fix this issue: #3729

For linting, please report to https://github.com/vuejs/eslint-plugin-vue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants