-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(store): init _customProperties
for devtools
#1704
Conversation
✅ Deploy Preview for pinia-official canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there are other places where _customProperties
are used that should also execute when adding devtools to prod
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also L671. Can you make sure that part runs with devtools as well?
Codecov Report
@@ Coverage Diff @@
## v2 #1704 +/- ##
==========================================
- Coverage 96.89% 96.16% -0.73%
==========================================
Files 12 12
Lines 3159 3158 -1
Branches 229 227 -2
==========================================
- Hits 3061 3037 -24
- Misses 95 118 +23
Partials 3 3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
_customProperties
when use devtool_customProperties
for devtools
Fix #1693