Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): init _customProperties for devtools #1704

Merged
merged 6 commits into from Oct 8, 2022
Merged

Conversation

rudyxu1102
Copy link
Contributor

@rudyxu1102 rudyxu1102 commented Oct 1, 2022

Fix #1693

@netlify
Copy link

netlify bot commented Oct 1, 2022

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 8dd8893
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/6341b5f456ecc000083e0bb0

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there are other places where _customProperties are used that should also execute when adding devtools to prod

@rudyxu1102 rudyxu1102 marked this pull request as draft October 3, 2022 13:21
@rudyxu1102 rudyxu1102 marked this pull request as ready for review October 3, 2022 13:52
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also L671. Can you make sure that part runs with devtools as well?

packages/pinia/src/store.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2022

Codecov Report

Merging #1704 (8dd8893) into v2 (9864beb) will decrease coverage by 0.72%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##               v2    #1704      +/-   ##
==========================================
- Coverage   96.89%   96.16%   -0.73%     
==========================================
  Files          12       12              
  Lines        3159     3158       -1     
  Branches      229      227       -2     
==========================================
- Hits         3061     3037      -24     
- Misses         95      118      +23     
  Partials        3        3              
Impacted Files Coverage Δ
packages/pinia/src/store.ts 89.91% <44.44%> (-2.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title fix(store): init _customProperties when use devtool fix(store): init _customProperties for devtools Oct 8, 2022
@posva posva merged commit 8c1dfce into vuejs:v2 Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Production Build + Vue Devtool Plugin Error
3 participants