Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugins): ensure plugins are used only once #745

Merged
merged 4 commits into from Oct 26, 2021
Merged

fix(plugins): ensure plugins are used only once #745

merged 4 commits into from Oct 26, 2021

Conversation

jessevanassen
Copy link
Contributor

@jessevanassen jessevanassen commented Oct 26, 2021 •
edited by posva

Fix #744

@jessevanassen jessevanassen mentioned this pull request Oct 26, 2021
Closed
posva
posva requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for test! Let's use a spy to count the amount of invocations.

packages/pinia/src/createPinia.ts Outdated Show resolved Hide resolved
packages/pinia/__tests__/storePlugins.spec.ts Outdated Show resolved Hide resolved
packages/pinia/__tests__/storePlugins.spec.ts Outdated Show resolved Hide resolved
@posva posva changed the title Only invoke plugins once after multiple installs - Fixes #744 fix(plugins): ensure plugins are used only once Oct 26, 2021
jessevanassen and others added 2 commits October 26, 2021 15:32
@jessevanassen @posva
test: use spy instead of a variable to track invocation count (#744)
41fa73b 
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
@jessevanassen @posva
fix: reinitialize _p instead of clearing the original array (#744)
f14fab3 
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
@posva posva merged commit 150fdfc into vuejs:v2 Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugins are duplicated for every createApp(...).use(pinia) call
2 participants
@jessevanassen @posva