Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): support IDE features for store context #924

Merged
merged 3 commits into from Dec 24, 2021
Merged

Conversation

johnsoncodehk
Copy link
Member

Fixed:

const useFoo = defineStore('foo', () => ({ bar: 123 }));
const foo = useFoo();
foo.bar // <-- renaming, goto definition, find references not working for bar

@netlify
Copy link

netlify bot commented Dec 24, 2021

✔️ Deploy Preview for pinia-official canceled.

🔨 Explore the source changes: 9d3e369

🔍 Inspect the deploy log: https://app.netlify.com/sites/pinia-official/deploys/61c5ca7b2eeb36000883724c

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Can you make sure the tests pass? Formatting seems to be failing

packages/pinia/src/types.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #924 (9d3e369) into v2 (b7b2c79) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #924   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           9        9           
  Lines         382      382           
  Branches       97       97           
=======================================
  Hits          381      381           
  Partials        1        1           
Impacted Files Coverage Δ
packages/pinia/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b2c79...9d3e369. Read the comment docs.

@posva posva merged commit 4733f49 into vuejs:v2 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants