Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check HTMLAnchorElement in saveAs for mini-program (#966) #967

Merged
merged 1 commit into from Jan 19, 2022

Conversation

odex21
Copy link
Contributor

@odex21 odex21 commented Jan 17, 2022

fix #966

@netlify
Copy link

netlify bot commented Jan 17, 2022

✔️ Deploy Preview for pinia-official canceled.

🔨 Explore the source changes: 451d9de

🔍 Inspect the deploy log: https://app.netlify.com/sites/pinia-official/deploys/61e5c70d9d5b860007c325fa

@codecov-commenter
Copy link

Codecov Report

Merging #967 (451d9de) into v2 (b0c3d5c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               v2     #967   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           9        9           
  Lines         382      382           
  Branches       97       97           
=======================================
  Hits          381      381           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3d210...451d9de. Read the comment docs.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note this file-saver code is removed in production as it's only used during dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTMLAnchorElement causes the mini program to crash
3 participants