Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #133 #134

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Fixes #133 #134

merged 2 commits into from
Mar 12, 2020

Conversation

wietseva
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #134 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   79.41%   79.41%           
=======================================
  Files          22       22           
  Lines         884      884           
  Branches      218      218           
=======================================
  Hits          702      702           
  Misses        144      144           
  Partials       38       38           
Impacted Files Coverage Δ
src/components/Link.ts 63.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3524622...560ca8c. Read the comment docs.

@wietseva wietseva changed the title Fixes vuejs / vue-router-next#133 Fixes #133 Mar 12, 2020
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test to the link spec please

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 392c295 into vuejs:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants