parseQuery override for end user & test #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushing parseQuery and test
BboyAkers
changed the title
BboyAkers
changed the title
posva
requested changes
Mar 15, 2020
|
Thanks! I'll start working on it first thing tomorrow! |
removed package-lock.json and fixed naming
posva
requested changes
Mar 16, 2020
|
You have a |
fixed stringify query test
pushing linted code
|
Done! Thoughts? |
posva
approved these changes
Mar 17, 2020
There was a problem hiding this comment.
Thanks @BboyAkers !
There are few minor things like wording that I will fix locally but the rest is good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think!