Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please reopen #3393 #1590

Closed
tstriker opened this issue Oct 28, 2022 · 2 comments
Closed

Please reopen #3393 #1590

tstriker opened this issue Oct 28, 2022 · 2 comments

Comments

@tstriker
Copy link

tstriker commented Oct 28, 2022

Version

4.1.6

Reproduction link

github.com

Steps to reproduce

As the comments on the bug attest, vuejs/vue-router#3393 was closed prematurely and has been ignored since. I suspect the bug report was simply misunderstood.

The problem is that the watchers aren't dismounted before route change, causing unexpected side-effects.

Would it be possible to take another look at the bug and reopen it—otherwise users of vue-router have to come up with clunky workarounds.

What is expected?

Leaving state shouldn't trigger watchers

What is actually happening?

Watchers are triggered

@tstriker
Copy link
Author

Ah, didn't realize the repos had been split up. Should i refile the bug with all the discussion from vuejs-router, or is this fine?

@posva
Copy link
Member

posva commented Oct 28, 2022

A bug report requires a reproduction, so if you open a new issue, please provide one:

This looks related to some of these in Vue 3 so in this case could you try reproducing it using https://jsfiddle.net/posva/pdv8gmr7/ as a base but with Vue 2.7? If there is a bug, then open an issue on vuejs/vue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants