Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 release preparation #985

Closed
xanf opened this issue Sep 29, 2021 · 13 comments
Closed

2.0 release preparation #985

xanf opened this issue Sep 29, 2021 · 13 comments

Comments

@xanf
Copy link
Collaborator

xanf commented Sep 29, 2021

#1253
#1233
#1173

Once these are fixed, we move to 2.0.

Edit: once the tests in this PR pass we move to 2.0: #1293

@xanf
Copy link
Collaborator Author

xanf commented Sep 29, 2021

My suggestion list:

@xanf
Copy link
Collaborator Author

xanf commented Sep 29, 2021

great! rocket

docs would need some additional love, too:

Definitely, first comment updated ❤️ 📝

@afontcu @lmiller1990 @cexbrayat Your input will be invaluable here
Let me know also about my suggestion list and for each accepted proposal I will open relevant issue here

@lmiller1990
Copy link
Member

lmiller1990 commented Oct 1, 2021

I think I have a fix for #806 somewhere, I can get it done this weekend.

I think we should tag all relevant issues with a 2.0.0 tag or something, so we do not need to track it manually.

How about we set a goal to make sure this happens - I'm going to suggest October 31st?

@boboldehampsink
Copy link

At the moment I'm seeing this issue: vuejs/vue-test-utils#1833 also in 2.0.0 rc 16.

@cexbrayat
Copy link
Member

cexbrayat commented Oct 13, 2021

@boboldehampsink The issue you're mentioning is for VTU v1 (for Vue v2), whereas this repository is for VTU v2 (for Vue 3)

If you're encountering it with Vue 3 and VTU v2, please open a dedicated issue with a reproduction so we can take a look.

@boboldehampsink
Copy link

@cexbrayat yes encountering this with Vue 3 and VTU v2. The issue is exactly the same tho. Probably worth fixing in v1 and then you'll be able to fix it for v2 too.

@boboldehampsink
Copy link

@boboldehampsink The issue you're mentioning is for VTU v1 (for Vue v2), whereas this repository is for VTU v2 (for Vue 3)

If you're encountering it with Vue 3 and VTU v2, please open a dedicated issue with a reproduction so we can take a look.

New issue filed here: #1076

@afontcu afontcu pinned this issue Dec 21, 2021
@lmiller1990
Copy link
Member

Seems, outside of Vue Jest specific problems w.r.t stubs, we are good to hit 2.0.0?

@lmiller1990
Copy link
Member

Once all fails here pass: #1293 we will do 2.0.

@ninjabhishek
Copy link

Is it good practice to release a version when the dependencies are yet not published properly. I have seen this with v5 of vue cli jest as well. v2 will hold v27-rc of vue-jest, shouldn't you guys collaborate and ask dependent libraries to publish first. This is not an issue with individual devs but there are scans in place in enterprises, and in my company, we are kind of confused to go with vue 3 now

@lmiller1990
Copy link
Member

lmiller1990 commented Mar 8, 2022

It's just a version number - transitioning from RC to 2.0.0 is more or less an arbitrary decision, since there's no official spec to build by. The RC - release candidate - just means "it's pretty much ready for prime time, bar a few known issues".

That said, if your company is concerned, the only thing blocking 2.0.0 is two failing tests: #1293.

If you (or someone else who's concerned about the RC status) would like to fix those, we can move to 2.0.0 🎉

@freakzlike
Copy link
Collaborator

I think this can be closed, as we finally have 2.0.0 🚀

@freakzlike freakzlike unpinned this issue Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants